fix: Dataset preview when every observation contains undefined values #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@bprusinowski can you replace the wrong line? this should keep the filtering logic where appropriate and do the trick to address the issue... |
bprusinowski
force-pushed
the
fix/dataset-preview-undefined-values
branch
from
6809f79 to
39a3c5a
Compare
|
That's indeed a better approach, thanks for catching this @Rdataflow 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1341.
This PR fixes dataset preview in cases when every observation contains undefined values.
Initially, the idea was to show "nice" previews by filtering out observations with undefined values; however it might happen that every observation will have at least one undefined value – we have to remove this condition to allow displaying such cubes.
How to test